feat: convert python enum into raw values before validating #317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blacha
force-pushed
the
fix/support-python-enum
branch
from
9ca8bde to
eb36134
Compare
Codecov Report
@@ Coverage Diff @@
## master #317 +/- ##
==========================================
+ Coverage 81.58% 81.60% +0.01%
==========================================
Files 57 57
Lines 5513 5513
==========================================
+ Hits 4498 4499 +1
+ Misses 1015 1014 -1
Continue to review full report at Codecov.
|
Stranger6667
requested changes
Nov 9, 2021
Owner
Stranger6667
left a comment
Stranger6667
left a comment
There was a problem hiding this comment.
I have a few small readability/naming comments, otherwise, it looks great to me!
Thank you for implementing this :)
Stranger6667
approved these changes
Nov 9, 2021
Owner
Stranger6667
left a comment
Stranger6667
left a comment
There was a problem hiding this comment.
Thanks! Looks good to me! I'll make a new release tomorrow :)
Owner
|
Released in 0.13.1 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #316