Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added unit tests for deposit and withdrawal functionalities. #12

Merged
merged 13 commits into from
Dec 1, 2024

Conversation

SoarinSkySagar
Copy link

resolves #5

@SoarinSkySagar SoarinSkySagar marked this pull request as ready for review November 29, 2024 21:25
@machuwey
Copy link
Collaborator

Hello @SoarinSkySagar, could please rollback al changes made to src/ contract files. Just to keep this PR clean an tidy and solely focused on the tests/.

Thank you.

@SoarinSkySagar
Copy link
Author

Hello @SoarinSkySagar, could please rollback al changes made to src/ contract files. Just to keep this PR clean an tidy and solely focused on the tests/.

Thank you.

yeah sure @machuwey, however most of the changes are from the scarb fmt command which lints all cairo code to increase code readability and neatness (does not change any code), do you want me to rollback that too?

@machuwey
Copy link
Collaborator

Hello @SoarinSkySagar, could please rollback al changes made to src/ contract files. Just to keep this PR clean an tidy and solely focused on the tests/.
Thank you.

yeah sure @machuwey, however most of the changes are from the scarb fmt command which lints all cairo code to increase code readability and neatness (does not change any code), do you want me to rollback that too?

Yes please, I solved all the warnings in a previous PR, if you want make another PR for the code linting that's ok for me. Thanks

@SoarinSkySagar
Copy link
Author

Yes please, I solved all the warnings in a previous PR, if you want make another PR for the code linting that's ok for me. Thanks

@machuwey okay, creating a new PR only for linting

@SoarinSkySagar
Copy link
Author

@machuwey done, all unnecessary changes rolled back

Copy link
Collaborator

@machuwey machuwey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nice job @SoarinSkySagar in laying out the foundation to test the contracts.

@machuwey machuwey merged commit 1dfa4f5 into StrapexLabs:main Dec 1, 2024
machuwey added a commit that referenced this pull request Dec 2, 2024
feat: added unit tests for deposit and withdrawal functionalities.
machuwey added a commit that referenced this pull request Jan 13, 2025
feat: added unit tests for deposit and withdrawal functionalities.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: unit tests for Deposit and withdrawal functionalities.
2 participants