-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: design a schema.prisma file #34
chore: design a schema.prisma file #34
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also propose changing the cuid
to uuid
ids as they are more of a industry standart.
packages/database/schema.prisma
Outdated
@@map("transactions") | ||
} | ||
|
||
model Subscription { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove the Subscription model out of the model for now because it was part of a most advanced feature testing in Strapex.
Make the PaymentType enum just onetime
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, doing that now...
Hey @GideonBature, could you please also reference the issue (#34) properly in the PR description just to keep everything documented? |
Definitely, I will do this too. Thank you for your review... |
Also, since it's a milestone, I honestly would love to work on the next one as well if given the opportunity to. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. We will have to wait for full integration to refine variables types and refine the model. As described, this will be merged to a separate branch.
Alright. Thank you ser! |
Description
[chore]: database schema definition
Related issue: #34
Changes Made
Type of Change
Testing
Test Instructions
pnpm install
Screenshots
Checklist
Additional Notes