Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: design a schema.prisma file #34

Conversation

GideonBature
Copy link

@GideonBature GideonBature commented Feb 22, 2025

Description

[chore]: database schema definition

Related issue: #34

Changes Made

  • Designed a schema.prisma file that reflects the app's core entities and relationships.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code refactoring
  • Performance improvement

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed

Test Instructions

  1. Checkout branch
  2. Run pnpm install
  3. Additional steps...

Screenshots

Checklist

  • My code follows the project's coding style
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • My changes generate no new warnings
  • New and existing unit tests pass locally
  • I have added tests that prove my fix/feature works
  • Any dependent changes have been merged and published

Additional Notes

Copy link
Collaborator

@machuwey machuwey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also propose changing the cuid to uuid ids as they are more of a industry standart.

@@map("transactions")
}

model Subscription {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove the Subscription model out of the model for now because it was part of a most advanced feature testing in Strapex.
Make the PaymentType enum just onetime

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, doing that now...

@jmartinn
Copy link
Collaborator

Hey @GideonBature, could you please also reference the issue (#34) properly in the PR description just to keep everything documented?

@machuwey machuwey requested a review from jmartinn February 23, 2025 16:44
@GideonBature
Copy link
Author

Hey @GideonBature, could you please also reference the issue (#34) properly in the PR description just to keep everything documented?

Definitely, I will do this too. Thank you for your review...

@GideonBature
Copy link
Author

Also, since it's a milestone, I honestly would love to work on the next one as well if given the opportunity to.

Copy link
Collaborator

@machuwey machuwey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. We will have to wait for full integration to refine variables types and refine the model. As described, this will be merged to a separate branch.

@machuwey machuwey merged commit c2b4559 into StrapexLabs:chore/SupabasePostgreSQLMigration Feb 24, 2025
@GideonBature
Copy link
Author

Alright. Thank you ser!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants