Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update to latest versions #42

Merged
merged 3 commits into from
Feb 28, 2025

Conversation

Psalmuel01
Copy link
Contributor

@Psalmuel01 Psalmuel01 commented Feb 27, 2025

close #29

Description

This PR introduced a new step to ensure that the scarb and snfoundry versions are updated to the latest, to ensure compatibility with the openzeppelin version.

Update upon @machuwey review:
Updated the scarb and snforge to the latest versions that support each other, any further version is either unstable or dont complement the other.

Related issue: #29

Changes Made

  • Figured what the issue was
  • Fixed by updating both scarb(starknet) and snfoundry locally
  • Updated the CONTRIBUTING.md to address necessary to take to work for others
  • Ran scarb build and snforge test to ensure they worked properly

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code refactoring
  • Performance improvement

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed

Test Instructions

  1. Checkout branch
  2. Run pnpm install
  3. Follow the additional steps to update in no 4. CONTRIBUTING.md

Screenshots

Checklist

  • My code follows the project's coding style
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • My changes generate no new warnings
  • New and existing unit tests pass locally
  • I have added tests that prove my fix/feature works
  • Any dependent changes have been merged and published

Additional Notes

@machuwey machuwey self-requested a review February 27, 2025 11:56
@Psalmuel01
Copy link
Contributor Author

@machuwey kindly please check pr

@machuwey machuwey self-requested a review February 28, 2025 12:43
@machuwey machuwey changed the base branch from main to chore/SupabasePostgreSQLMigration February 28, 2025 12:43
@machuwey machuwey changed the base branch from chore/SupabasePostgreSQLMigration to main February 28, 2025 12:44
@machuwey machuwey merged commit 94dcc1a into StrapexLabs:main Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat]: update to latest starknet & cairo version
2 participants