Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transactions): remove subscription if available #230

Merged
merged 1 commit into from
May 7, 2022
Merged

fix(transactions): remove subscription if available #230

merged 1 commit into from
May 7, 2022

Conversation

wozgun
Copy link
Contributor

@wozgun wozgun commented May 7, 2022

Signature subscriptions are not available when the Connection object is used with a browser bundler. This PR adds a fail-safe for _signatureSubscriptions property of connection object removing the listener only when the subscriptions property is available.

@vercel
Copy link

vercel bot commented May 7, 2022

@wozgun is attempting to deploy a commit to the Strata Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@bryzettler bryzettler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bryzettler bryzettler merged commit e99f05c into StrataFoundation:master May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants