-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update readme for v6.18 #2242
Update readme for v6.18 #2242
Conversation
WalkthroughThe pull request updates the Formidable Forms plugin to version 6.18. Both the changelog and readme documents have been revised to reflect a series of enhancements and fixes. Changes include a visual update where invalid checkbox fields now show a red outline, corrections to CSS class application and dropdown field width behavior, and an adjustment to multi-select field interaction. Additionally, the option to exclude Formidable from the admin bar has been relocated, the deprecated Stripe file has been removed, and the stable tag in the readme has been updated. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
readme.txt (1)
374-381
: Changelog for Version 6.18 Documented.
The changelog section clearly lists the new feature and fixes introduced in version 6.18. For consistency, consider prefixing the fourth bullet with "Fix:" so that all items follow a uniform style. For example:-* Text will no longer be selected when multi-selecting fields while holding the shift key. +* Fix: Text will no longer be selected when multi-selecting fields while holding the shift key.This minor adjustment will improve clarity and consistency in the changelog.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
changelog.txt
(1 hunks)readme.txt
(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: PHP 8 tests in WP trunk
- GitHub Check: PHP 8 tests in WP trunk
- GitHub Check: Cypress
- GitHub Check: PHP 7.4 tests in WP trunk
- GitHub Check: PHP 7.4 tests in WP trunk
- GitHub Check: Cypress
🔇 Additional comments (2)
readme.txt (1)
8-8
: Stable Tag Updated Correctly.
The stable tag on line 8 has been updated to "6.18" as intended. Verify that all cross-references (e.g., in documentation or related files) are consistent with this change.changelog.txt (1)
2-9
: Review of v6.18 Changelog Section
The v6.18 header (“= 6.18 =”) is clearly indicated and the list items succinctly describe the updates:
- New Feature: Invalid checkbox fields now display a red outline to improve user experience.
- Fixes:
- Additional CSS classes in Formidable block settings are now consistently applied to Forms containers.
- Automatic width for dropdown fields (with labels positioned left or right) now functions as expected.
- Unintended text selection when multi-selecting fields (while holding the shift key) is prevented.
- The setting to exclude Formidable from the admin bar has been relocated to miscellaneous settings.
- The deprecated file
stripe/views/payments/entry_sidebar.php
has been removed.Suggestions:
- For consistency, consider explicitly prefixing the correction on line 6 with “Fix:” or “Improvement:” so that all entries follow a uniform style.
- Verify that these v6.18 updates are also reflected in the README file as per the PR title ("Update readme for v6.18") to ensure consistency across documentation.
Overall, the changelog segment for v6.18 is clear and concise, reflecting the intended enhancements and fixes.
No description provided.