-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table names from cube. SPARKTA-184 #1337
Conversation
case true => Seq(dimensionValuesT.time) | ||
case false => Seq(DateOperations.millisToTimeStamp(dimensionValuesT.time)) | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you rebase from master, the time.value calculation is new in aggregateOperations and SchemaFactory:
Mantain the new calculation:
Seq(getTimeFromDateType(dimensionValuesT.time, dateType))
Now is working. Rebase done, thanks @gserranojc |
In the documentation it is mentioned where the cube name comes from. Please update documentation |
Changes done in docs, thanks |
+1 |
MILF +1 |
Table names from cube. SPARKTA-184
* WIP actor quality rule (cherry picked from commit a8ccd0267bf97ae0081a203fba68c7e8049c7751) * WIP actor quality rule (cherry picked from commit a8ccd0267bf97ae0081a203fba68c7e8049c7751) * [SPARTA-2874] Create services and actors needed to persist DQ results (#1346) (cherry picked from commit f160f508f2b271880b614b8a0b4c93cd148da3f4) * Feature/quality rules phase retrieve (#1348) * Quality rules phase retrieve * Phase retrieve working with mock data (cherry picked from commit 975e384afcda1bebf45a670ed0177d36237ddced) * force initial date in scheduled tasks (#1417) [BBVA-DATIO] Force initial date in scheduled tasks (cherry picked from commit 06c2c5d4982b1cb9894ff24af7330fca87c9732d) * Feature/quality rules singleton 2 (#1418) * WIP actor quality rule * Feature/quality rules phase retrieve (#1348) * Quality rules phase retrieve * Phase retrieve working with mock data * Add cluster singleton in QualityRuleActor * [SPARTA-2826][SPARTA-2828][SPARTA-2801] Spark conversion (#1337) * Inside writeTemplate * Added new Operations and Tests * Change Date and Timestamp checks * Bottom-up * Top-Down * Added enable flag * Working all the pieces * Sent to governance * Add condition as string * cache and fixthreshold * Sent only once * Added more logs * Change to Event bus listener * Last clean * infernal merge (cherry picked from commit 8ed7d66614f14c25c2d42d4d8f4d8a5a029d6031) * Required changes (cherry picked from commit 8ddc7e97f4b50389ce21ff6bbf0938da8962255a) * Add stratety to choose an output mode (cherry picked from commit c75634133960687f2c27168fe8a368915da8b1d4) * [SPARTA-2930] Add details of sparta results to pass to front (#1432) (cherry picked from commit e39707fb5fcb40d375a41668abd7aa852b8922be) * Endpoint return empty array instead of exception (cherry picked from commit 8da228fc99fa7f22a33af6473ae3a73316558eef) * CHange package * Prepare for merging the spark stuff * Mix Scheduler and QR in Launcher * Solve some merge problems * Required changes * Pass executionId * Add migration+
Description
Table names from cube. SPARKTA-184
Reviewer
@gserranojc
Test
All OK
Coverage
No changes
Scalastyle
No info