Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore .babelrc when publishing #23

Closed
wants to merge 1 commit into from
Closed

Conversation

ryb73
Copy link

@ryb73 ryb73 commented Sep 15, 2017

This causes problems when using webpack to compile a project which is dependent on react-draggable-list. It tries using the .babelrc but AFAICT that's not necessary because the source was already transpiled before being published.

@Macil
Copy link
Collaborator

Macil commented Sep 17, 2017

Genuine thanks for looking to improve the project, but I'm inclined to follow redux-optimist's lead here.

I don't want to take this as there are other reasons running babel against node_modules will break things and merging this encourages people to think it's a good idea to do so. I also don't want to have to make the same change to all my other packages or leave all the other module authors in the position of having to do the same thing.

Users shouldn't be transpiling pre-transpiled files under node_modules. Failing fast like this lets users know they're doing something wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants