Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created new /subscription/ topic to forward full sender information on a connection #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

danickd
Copy link
Contributor

@danickd danickd commented Aug 9, 2016

No description provided.

@danickd
Copy link
Contributor Author

danickd commented Aug 9, 2016

There is probably a better way to do this. Let me know if you have any ideas and I'll be happy to change it.

@Mammouth2727
Copy link

Will this pull request ever be merged? This is actually quite useful. With this minor change a node can react to a receiver's subscription being set/unset.

@fschoett
Copy link

I also think that this adds a very important functionality. I have implemented the changes in my project and they are working perfectly. It seems that there is not much activity any more on this project though?

Anyways, thank you @danickd for the useful changes you did 3 years ago 👍 Until ledger fully supports the connectionAPI i have to use this solution.

@danickd
Copy link
Contributor Author

danickd commented Jul 17, 2019

Thanks @fschoett
By now most of use moved to the C++ implementation that is free from Sony. I suggest you take a look at it since it supports all the newer standards.

@fschoett
Copy link

@danickd Thank you for your reply and the tip. Very sad to here. I already took a look at Sony´s implementation, but i wanted to use a JS framework, as my current project is mainly written in JS and working with JSONs is obviously more easy. I will finish a prototype with this framework though and after that find out if there is any chance of implementing Sony`s framework.

A shame. This framework was quite easy to implement and to use...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants