Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent freeze app on streaming #122

Merged
merged 1 commit into from
Jul 28, 2016
Merged

Conversation

kjpolaszek
Copy link
Contributor

It should prevent freeze app on streaming

self.playerItems = playerItems;
}

if ([self getLastItemIndex] == index) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a truly needed, much appreciated

@saiday
Copy link
Member

saiday commented Jul 28, 2016

That is an awesome approach!

@saiday saiday merged commit 662e7d4 into StreetVoice:master Jul 28, 2016
@mkc842
Copy link

mkc842 commented Aug 2, 2016

@kjpolaszek - what was your intent with this line?

if ([self getLastItemIndex] == index) {

For me, it causes the first item in the player to play twice.

I have commented out the if statement, and call [self insertPlayerItem:item]; unconditionally, as before.

saiday added a commit that referenced this pull request Dec 4, 2016
This reverts commit 662e7d4, reversing
changes made to 4945c26.
@patrickjquinn
Copy link

Can we re-open this and find a working solution that doesn't throw errors or repeat the last audio file once another one is added!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants