This repository has been archived by the owner on Jun 4, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2k
WIP: Refactor OpenConnect VPN client instructions into user selectable client profiles #1409
Open
alimakki
wants to merge
12
commits into
StreisandEffect:master
Choose a base branch
from
alimakki:ocserv_cli_instructions
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
WIP: Refactor OpenConnect VPN client instructions into user selectable client profiles #1409
alimakki
wants to merge
12
commits into
StreisandEffect:master
from
alimakki:ocserv_cli_instructions
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alimakki
added
kind/cleanup
kind/docs
area/openconnect
status/group-decision-needed
For items that need discussion by the maintainers
labels
Jul 22, 2018
alimakki
requested review from
jlund,
cpu,
nopdotcom,
CorbanR and
nickolasclarke
July 22, 2018 01:07
I think the drop-down boxes boxes shouldn't start off blank; they should say something like "- Client profiles...". |
That sounds reasonable, will change. |
alimakki
force-pushed
the
ocserv_cli_instructions
branch
from
August 5, 2018 21:02
7b6b6ba
to
d29c738
Compare
- cli instructions are displayed as selected
- revert some commented out roles
alimakki
force-pushed
the
ocserv_cli_instructions
branch
from
October 14, 2018 12:58
1d45adb
to
a7b6f41
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area/openconnect
kind/cleanup
kind/docs
status/group-decision-needed
For items that need discussion by the maintainers
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Streisand's current strategy of generating instructions for OpenConnect poses a number of usability issues when attempting to follow client specific instructions:
This PR attempts to address these issues by displaying per-client instructions where relevant, selectable via a drop down menu for each device that requires it.
The following platforms have been refactored:
In order to continue leveraging our current markdown templates and provide support for selectable instructions, the use of
<div>
elements were necessary; the originalmarkdown
only operates on<span>
level elements and caused rendering issues, thus needed to be replaced with a python implementation of markdown. While the final result does appear to be faithful, some quirks are apparent and warrants discussion.Screenshots:
Comments and feedback appreciated!