Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/VideoDeepLinks for Player and MetaDetails + send more events #70

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Feat/VideoDeepLinks for Player and MetaDetails + send more events #70

wants to merge 4 commits into from

Conversation

elpiel
Copy link
Member

@elpiel elpiel commented Dec 17, 2024 •
edited
Loading

  • Includes additions to the emitted analytics events.

@elpiel
feat(stremio-core-kotlin): AndroidEnv - emit more events
b9fc79e 
Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
@elpiel
feat(stremio-core-protobuf): VideoDeepLinks for MetaDetails and Player
b73d1fd 
Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
@elpiel elpiel changed the title Feat/video deep links Feat/VideoDeepLinks for Player and MetaDetails Dec 17, 2024
@elpiel elpiel changed the title Feat/VideoDeepLinks for Player and MetaDetails Feat/VideoDeepLinks for Player and MetaDetails + send more events Dec 17, 2024
@elpiel
fix(stremio-core-kotlin): Player & MetaDetails to_protobuf args
e5731b1 
Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
tymmesyde
tymmesyde approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@tymmesyde tymmesyde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only tested VideoDeepLinks

@elpiel
Copy link
Member Author

elpiel commented Dec 20, 2024

thanks @tymmesyde .
yes, the events are take from another platform 1=1 so they should not be a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tymmesyde tymmesyde tymmesyde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elpiel @tymmesyde