Fix: Performance issues and 404 page #535
Open
+100
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolved issues with html rendering and proper syntax
Browsers that are old will have broken css, this will resolve most of it
Rather than formatting the caching and 404 for all the routes, we can define a fallthrough to handle the 404 errors and redirect to the page for it
Add lazy loading to progressively show the images, rather than broken in increments
Users can drag an image and place it on the 404 page, causing a parsing error. Locking the image will fix it, however will need to turn off parsing in the future for dragging images on the page
Added vertical navbar to the 404 page. Fixed issues with the page structure in css
Removed old solution, caused memory problems on main page. Made all images not draggable as posters and logos were draggable prior
|
Hi, can you split those changes into different PRs ? |
|
I'll do it later today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#534