feat: calendar #651
Merged
feat: calendar #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kKaskak
previously approved these changes
Jul 4, 2024
…into feat/calendar
kKaskak
previously approved these changes
Nov 19, 2024
There was a problem hiding this comment.
LGTM!
One thing to mention:
- The Calendar label is cut both on the desktop
VerticalNavbarand while on mobile. (It will surely depend on the translations as well). Might not be entirely fixable.
(wanted to merge development in but the integrity in the core pkg in gh pages release is broken and needs to be fixed for the tests to pass)
kKaskak
force-pushed
the
feat/calendar
branch
from
42d8d3f to
9df9a4e
Compare
kKaskak
previously approved these changes
Nov 19, 2024
kKaskak
previously approved these changes
Nov 20, 2024
elpiel
previously approved these changes
Nov 26, 2024
…into feat/calendar
fix: navbar item label was cut
elpiel
previously approved these changes
Nov 28, 2024
elpiel
previously approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes:
For testing: