Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multiselectMenu and Multiselect height #742

Merged
merged 5 commits into from
Dec 12, 2024

Conversation

kKaskak
Copy link
Member

@kKaskak kKaskak commented Dec 11, 2024

  • The height of the Multiselect and MultiselectMenu was not calculated properly.

  • After fixing the problem with the pop-up overflow some time ago a new problem is getting fixed here with dropdowns inside pop-ups on being visible (another time overflow issue) i propose we move away from popups completely in the future

  • Changes introduced:

  1. We set the height only globally for the component and try not to set it locally for each case.
  2. We use @media (orientation: landscape) and (max-width: @xsmall) to set the size for smaller landscape devices (there are no devices that are vertical and are smaller than calc(3.2rem * 7))
  3. Overflow issue on popups having dropdowns resolved.
  • Future notes:
  1. Move completely to using MultiselectMenu component instead of the old MultiSelect

Now

image
image
image

Before

image
image

@kKaskak kKaskak added the quick fix A quick fix to a bug label Dec 11, 2024
@kKaskak kKaskak requested a review from tymmesyde December 11, 2024 10:34
@kKaskak kKaskak self-assigned this Dec 11, 2024
@tymmesyde tymmesyde merged commit cbfd920 into development Dec 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quick fix A quick fix to a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants