v14 cleanup #1017
Merged
v14 cleanup #1017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riley-stride
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
Great memory to get this in the upgrade. And thanks for linking to the relevant comment, made the review very easy.
To make sure we have a good system for to-dos going forward: where do you typically track to-dos for future upgrades? I see the // TODO in the code, do you typically search for those before cutting an upgrade?
|
I don't really have a system - just happened to notice this! Fwiw, I'm not sure there are any other pressing TODOs, but if there are we can just make a GH issue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
For upgrade v14, we added the field
DelegationChangesInProgressinitialized to 0. There was a tail risk that there would actually be an ICA in progress at the time that the upgrade happened, so we had temporarily swallowed an error case of the changes going below 0.Now that the upgrade has succeeded and this case should no longer be possible, we can go back to throwing an error.
[Relevant PR]
[Relevant Comment]
Brief Changelog