Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

whitelisted all gov proposals #1028

Merged
merged 3 commits into from
Jan 5, 2024
Merged

whitelisted all gov proposals #1028

merged 3 commits into from
Jan 5, 2024

Conversation

sampocs
Copy link
Collaborator

@sampocs sampocs commented Dec 14, 2023

Context

Whitelisting all gov proposals because:

  • It's a burden to maintain the list
  • There have been multiple proposals that have been deleted on mainnet because of this
  • This was mostly intended to block param changes to the CCV module - which are still possible in other ways

Brief Changelog

  • Returned true in IsWhitelist functions to whitelist all gov proposals
  • Removed antehandler

@sampocs sampocs added the v17 label Dec 19, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2024

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you!

@github-actions github-actions bot added the Stale label Jan 3, 2024
asalzmann
asalzmann approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@asalzmann asalzmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you for doing this!

cc @jtremback

app/app.go Show resolved Hide resolved
@github-actions github-actions bot removed the Stale label Jan 4, 2024
@sampocs sampocs added the A:automerge Automatically merge PR once checks pass label Jan 4, 2024
@mergify mergify bot merged commit a1944f5 into main Jan 5, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asalzmann asalzmann asalzmann approved these changes

Assignees
No one assigned
Labels
A:automerge Automatically merge PR once checks pass C:app-wiring v17
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sampocs @asalzmann