upgraded to ics v3.2.0 #1043
Merged
upgraded to ics v3.2.0 #1043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
dependencies
I was wondering the same thing haha, I think it's cause I cherry picked the commit so it probably keeps the original author |
|
Also, fyi, I haven't been able to get this to build yet. Working on something else rn, but will come back to it tomorrow |
riley-stride
approved these changes
Jan 9, 2024
There was a problem hiding this comment.
Really impressive work jumping into this and figuring it out so quickly.
The tests look to be equivalent, so I'd expect full ICS test coverage after this change.
My main takeaway is that we made some changes to how the initial validator set is passed into the consumer genesis as the stride chain's initial set.
asalzmann
approved these changes
Jan 10, 2024
review ^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Upgraded ICS to v3.2. We previously used a fork of ICS that had ibctesting infra for our unit tests; however, the fork is no longer necessary as it has been moved to ibc-go v7.3.
Brief Changelog