-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move disable tokenization to hooks #1066
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to query whether an acct has tokenization disabled? If so we should test this with a quick script in dockernet.
Found it. We can query |
yeah I'm testing at the moment |
@riley-stride @asalzmann Successfully tested on dockernet - added testing steps to PR description |
…ride into move-disable-tokenization
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm pending the .gitmodules / dockerfile changes
Context
Submitting the detokenization ICA from the upgrade handler doesn't seem trivial. Instead, we're temporarily moving it to hooks and will remove in the next upgrade.
Brief Changelog
Testing Strategy
cosmoshub-4
chain-id toGAIA
in the code and changed it to run every day epoch (instead of every 10)>>> gaiadl q staking tokenize-share-lock-info cosmos1eld82php5h2dpgke8ansn5pajrgu69pzkpajn0mkuf3ujk6lvz9qyvdd48 expiration_time: "" status: TOKENIZE_SHARE_LOCK_STATUS_UNLOCKED