reset delegation change in progress to 0 when a channel is restored #1074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
Context
The
DelegationChangesInProgressfield on the validator struct is a mechanism to prevent ICA/ICQ overlap. When ICAs are submitted, theDelegationChangesInProgressfield is incremented, and when the ack comes back, it is decremented.In order to prevent ICA/ICQ overlap, when a slash ICQ is relayed, it [checks] if there are any active delegation changes in progress, and if so, the query is retried (since the results can’t be trusted)
However, when an ICA packet times out, the channel is closed and the pending packets are never relayed. Since we never receive the ack for these packets, the
DelegationChangesInProgressfield never gets decremented.This PR sets the
DelegationChangesInProgressfield to 0 when the ICA channel is restored.Brief Changelog
DelegationChangesInProgressto 0 when a channel is restored and added unit test