V18 Upgrade Migrations #1084
Merged
V18 Upgrade Migrations #1084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pgrade-migrations
x/stakeibc/keeper/unbonding_records_get_host_zone_unbondings_msgs_test.go
Show resolved
Hide resolved
riley-stride
requested changes
Jan 25, 2024
asalzmann
reviewed
Jan 25, 2024
sampocs
force-pushed
the
v18-upgrade-migrations
branch
from
5d26eb8 to
a1773ab
Compare
sampocs
reviewed
Jan 25, 2024
Co-authored-by: sampocs <sam@stridelabs.co>
asalzmann
reviewed
Jan 25, 2024
shellvish
commented
Jan 25, 2024
asalzmann
reviewed
Jan 26, 2024
| NativeTokenAmount: initialNativeAmount2, | ||
| }) | ||
|
|
||
| // Create epoch unbonding records |
There was a problem hiding this comment.
Should we test records in other statuses?
There was a problem hiding this comment.
was considering that too, but didn't want the test to get too bloated.
Happy to add it in the morn if you think it makes sense!
There was a problem hiding this comment.
Maybe just one other status to make sure the record filtering works
Co-authored-by: sampocs <sam.pochyly@gmail.com>
Co-authored-by: Riley Edmunds <riley@stridelabs.co>
…e into v18-upgrade-migrations
riley-stride
approved these changes
Jan 26, 2024
This reverts commit 2f2f290.
…e into v18-upgrade-migrations
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates User Redemption Records to new format in v18 upgrade
Note: we should test this twice with LocalStride. First, with a slightly stale cache, so we can more accurately gauge what will happen at upgrade time. Second, with the most recent mainnet state (as part of the standard localstride flow).
TODO: Add Unit Tests