-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cosmwasm #1103
Add cosmwasm #1103
Conversation
per open questions:
Discussed offline, in agreement. Need to remember to set the instantiate address when uploading.
Successful hyperlane deployment confirms we do not need any of these
I believe these are just validator config settings so easy to change later if needed. And I assume the defaults are fine since this is a light-weight deployment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
As discussed none of us are experts for many of these settings so I am just calling out anything which looks potentially unneeded at this point. I was comparing against the osmosis cosmwasm setup but they probably have additional usecases we don't want so we might be able to lock it down even more.
Context
Added permissioned cosmwasm to Stride for hyperlane
Brief Changelog
Context on Permissions
Open Questions
Testing
This was tested with the ICA oracle contract
Testing w/o Upgrade
First this was tested without the upgrade and with open permissions
Testing Permissioned Upload after Upgrade
This was then tested via running an upgrade and confirming the permissions were set correctly
cannot create code: unauthorized
Testing Permissioned Instantiation after Upgrade
Continuing off the previous example:
cannot instantiate: unauthorized