Add Default Config Settings #1245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampocs
approved these changes
Jul 19, 2024
sampocs
reviewed
Jul 19, 2024
| // | ||
| // Silently handles and skips any error/panic due to write permission issues. | ||
| // No-op otherwise. | ||
| func overwriteConfigTomlValues(serverCtx *server.Context) error { |
There was a problem hiding this comment.
nit: are the config and app toml functions identical besides the reference to "config.toml/app.toml" and "recommendedConfigTomlValues/recommendedAppTomlValues"? If so, might make sense to consolidate the functions
sampocs
added
A:automerge
…stride into add-default-config-settings
sampocs
added
A:automerge
HEGred
approved these changes
Jul 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heavily inspired by Osmosis default config.toml+app.toml settings.