Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed autopilot support for metadata in receiver and increased memo lengths #1273

Merged
merged 8 commits into from
Aug 28, 2024

Conversation

sampocs
Copy link
Collaborator

@sampocs sampocs commented Aug 27, 2024

Context and purpose of the change

Now that all our host zones are beyond IBC version 5, we can deprecate the autopilot format that accepts the metadata JSON in the receiver field. This PR also updates the max length for the receiver and memo fields (thanks to @PoolPirate, #1255)

Brief Changelog

  • Removed support for autopilot metadata in the receiver
  • Updated the max memo length to 4096 and the max receiver length to 100
  • Enforced that the receiver is a valid address and matches the address in the memo
  • Updated unit tests and integration tests

Integration Tests

 ✓ [INTEGRATION-BASIC-GAIA] host zones successfully registered
 ✓ [INTEGRATION-BASIC-GAIA] ibc transfer
 ✓ [INTEGRATION-BASIC-GAIA] liquid stake mint and transfer
 ✓ [INTEGRATION-BASIC-GAIA] delegation on GAIA
 ✓ [INTEGRATION-BASIC-GAIA] LSM liquid stake
 ✓ [INTEGRATION-BASIC-GAIA] LSM liquid stake with slash query
 ✓ [INTEGRATION-BASIC-GAIA] autopilot liquid stake
 ✓ [INTEGRATION-BASIC-GAIA] autopilot liquid stake and transfer
 ✓ [INTEGRATION-BASIC-GAIA] autopilot redeem stake
 ✓ [INTEGRATION-BASIC-GAIA] redemption and undelegation on GAIA
 ✓ [INTEGRATION-BASIC-GAIA] claim redeemed tokens
 ✓ [INTEGRATION-BASIC-GAIA] rewards are being reinvested, exchange rate updating
 ✓ [INTEGRATION-BASIC-GAIA] rewards are being distributed to stakers

x/autopilot/module_ibc.go Outdated Show resolved Hide resolved
x/autopilot/module_ibc.go Show resolved Hide resolved
@asalzmann
Copy link
Contributor

LGTM

@sampocs sampocs merged commit 930d4eb into main Aug 28, 2024
10 checks passed
@sampocs sampocs deleted the remove-autopilot-memo branch August 28, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants