Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed osmosis swap type URL #1275

Merged
merged 8 commits into from
Aug 28, 2024
Merged

changed osmosis swap type URL #1275

merged 8 commits into from
Aug 28, 2024

Conversation

sampocs
Copy link
Collaborator

@sampocs sampocs commented Aug 27, 2024

Context

The dydx trade route swapper current receives authz permissions to execute message /osmosis.gamm.v1beta1.MsgSwapExactAmountIn. However, this is a legacy message. This PR updates the permissions to use the pool manager message instead.

Brief Changelog

  • Removed osmosis protos (no longer needed since we don't have to actually build the message)
  • Updated osmosis type url to the pool manager one

NOTE: We'll want to revoke the gamm permissions right before the upgrade and then grant this new message type right after the upgrade

Copy link
Contributor

@shellvish shellvish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for doing this!

@sampocs sampocs requested a review from shellvish August 28, 2024 13:45
@sampocs
Copy link
Collaborator Author

sampocs commented Aug 28, 2024

@shellvish Added a --legacy flag to allow us to still revoke the gamm type url if you can review the latest commit! 392be8e

Copy link
Contributor

@shellvish shellvish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks for doing this!

@sampocs sampocs merged commit f4cee77 into main Aug 28, 2024
10 checks passed
@sampocs sampocs deleted the changed-osmo-swap-msg branch August 28, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants