-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add utils.SafeSendCoins() #1373
base: main
Are you sure you want to change the base?
Conversation
didn't change tests and past upgrade handlers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
I'm wondering if it would make more sense to just parameterize safe send coins with a checkBlockedAddr
bool so that we could use it for every SendCoins
instance instead of having to add the comment that says why we didn't use it
Good point. I'm not sure if it'll be more readable tho, from the outside it'll just be true/false. I'll do it and see how it looks. Also, wdyt about adding a ci job to check that we're not using SendCoins anywhere in the future? |
Ooo CI job is a great idea! (assuming we stick with the switch to using SafeSend everywhere) |
Yeah with the switch. |
e6312fd
to
5af8c8d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! one last request - I would revert the test files and change the CI job to ignore test files. I think it's fine to use the bank one for those since we want them to be as non-verbose as possible
didn't change tests and past upgrade handlers