[TEST-12][1] Prep ICA staking by fixing some bugs #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -27,6 +27,10 @@ require ( | |||
| ) | |||
|
|
|||
| replace ( | |||
| // TODO(TEST-54): Should we delete this replace statement and use the core cosmos-sdk for mainnet? | |||
riley-stride
approved these changes
May 27, 2022
asalzmann
pushed a commit
that referenced
this pull request
Jan 25, 2024
Co-authored-by: sampocs <sam.pochyly@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In preparation to add ICA staking functionality, fix a few bugs. These are
make init, @vish-stride pointed out that the reasonmake init build={stride, strideall}wasn't working was that some flags were missingapp.ICAControllerKeeperaboveapp.StakeibcKeeperinapp.go.app.ICAControllerKeeperwas initialized belowapp.StakeibcKeeper, so calls toICAControllerKeepercurrently fail.ALLOW_MESSAGESto the gaiagenesis.jsonfiles so that ICA calls are enabled. Per the ICA docs, allow messages must be defined in order for a controller chain to control an ICA.This is the first of 3 PRs to add interchain staking to
stakeibc, the remaining PRs willstakeibcso that host chain staking happens on a regular cadenceTest plan
ignite chain buildandignite chain serveDraft PR: #12