Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pfm #889

Merged
merged 17 commits into from
Jan 10, 2024
Merged

add pfm #889

merged 17 commits into from
Jan 10, 2024

Conversation

asalzmann
Copy link
Contributor

@asalzmann asalzmann commented Aug 9, 2023

closes #800

Summary
Adds PFM by following the integration guide: https://github.com/cosmos/ibc-apps/blob/main/middleware/packet-forward-middleware/docs/integration.md

Tracking a few integration issues with the PFM team:
cosmos/ibc-apps#146

I asked about these discrepancies on the issue (waiting on a response from Reece) for 1/2

  • Why is app.GetSubspace in the integration docs but not the code?
  • Why is the authority not in the integration docs but in the code?
  • Should we import app.PacketForwardKeeper in app.TransferKeeper? => Not required, just pass nil

@github-actions github-actions bot added C:app-wiring dependencies Pull requests that update a dependency file labels Aug 9, 2023
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you!

@github-actions github-actions bot added the Stale label Aug 24, 2023
@github-actions github-actions bot closed this Aug 30, 2023
@SecretSaturn
Copy link

hey @asalzmann,

Stride's UX would really profit a lot from having PFM enabled.
We at Secret network would like to bridge in a lot of stride assets directly from osmosis and PFM would ease the UX quite a lot! :)

@github-actions github-actions bot removed the Stale label Nov 29, 2023
app/app.go Outdated Show resolved Hide resolved
app/app.go Outdated Show resolved Hide resolved
app/app.go Outdated Show resolved Hide resolved
app/app.go Show resolved Hide resolved
app/app.go Outdated Show resolved Hide resolved
app/app.go Outdated Show resolved Hide resolved
app/upgrades.go Outdated Show resolved Hide resolved
app/app.go Outdated Show resolved Hide resolved
@sampocs sampocs added the v17 label Dec 19, 2023
@asalzmann
Copy link
Contributor Author

@sampocs are you signed off on this PR?

Is the main outstanding task to review interaction between autopilot / PFM?

@sampocs
Copy link
Collaborator

sampocs commented Jan 5, 2024

I’m signed off on all the comments, but remaining tasks are:

  • think about the interaction between autopilot snd pfm
  • test it in dockernet if you havent already
  • fix whatever the build error is that’s causing CI to fail

@asalzmann
Copy link
Contributor Author

asalzmann commented Jan 10, 2024

  • think about the interaction between autopilot snd pfm
  • test it in dockernet if you havent already
  • fix whatever the build error is that’s causing CI to fail

@github-actions github-actions bot removed the T:build label Jan 10, 2024
@sampocs sampocs merged commit eb86bd5 into main Jan 10, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:app-wiring dependencies Pull requests that update a dependency file v17
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants