Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup v15 #950

Merged
merged 32 commits into from
Dec 14, 2023
Merged

Cleanup v15 #950

merged 32 commits into from
Dec 14, 2023

Conversation

riley-stride
Copy link
Contributor

@riley-stride riley-stride commented Oct 11, 2023 •
edited by sampocs
Loading

Closes: #XXX

UNDELEGATEHOST #935

  • Remove undelegatehost tx

CALIBRATION #936

  • Remove admin gate on calibration tx
  • Limit adjustment to record keeping by 3000microdenom
  • Do not block ICAs (there is no need to since we cap the record keeping change)

@riley-stride
undel host: revert all logic, add back undelcb proto + proto-gen
c0b6b99
@riley-stride
Merge branch 'cleanup_v15' of ssh://github.com/Stride-Labs/stride int…
2742044 
…o cleanup_v15
@riley-stride
undel host: re-add tx update delegation
4c42dfe
@riley-stride
calibration: revert proto + protogen; re-add delegation protos from u…
e8bad99 
…ndel host
@riley-stride
calibration: logic cleanup
876b1e0
@riley-stride
calibration: fix typo
00f5f27
@riley-stride
Revert "calibration: fix typo"
2541d18 
This reverts commit 00f5f27.
@riley-stride
Revert "calibration: logic cleanup"
7f8e57e 
This reverts commit 876b1e0.
@riley-stride
Revert "calibration: revert proto + protogen; re-add delegation proto…
d897ace 
…s from undel host"

This reverts commit e8bad99.
@riley-stride
undel host: add back undelegatecallback + proto-gen
753bdce
@riley-stride
calibrate: rm admin gate
57d61c6
@riley-stride
calibration: do not block ICAs
9463f14
@riley-stride
calibration: limit calibration adjustment to record keeping to <1000m…
9e2c398 
…icrodenom
@riley-stride
calibration: limit calibration adjustment to record keeping to <1000m…
dea43a7 
…icrodenom
@riley-stride
Merge branch 'cleanup_v15' of ssh://github.com/Stride-Labs/stride int…
1b1095b 
…o cleanup_v15
@riley-stride riley-stride marked this pull request as ready for review October 11, 2023 09:57
@riley-stride riley-stride requested review from asalzmann, dev-stride and shellvish and removed request for dev-stride October 11, 2023 13:47
sampocs
sampocs reviewed Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@sampocs sampocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for doing this! Couple small discussion point below:

x/stakeibc/keeper/msg_server_submit_tx.go Outdated Show resolved Hide resolved
x/stakeibc/keeper/icqcallbacks_callibrate_delegation.go Show resolved Hide resolved
x/stakeibc/keeper/icqcallbacks_callibrate_delegation.go Outdated Show resolved Hide resolved
x/stakeibc/keeper/icqcallbacks_callibrate_delegation.go Outdated Show resolved Hide resolved
x/stakeibc/keeper/icqcallbacks_callibrate_delegation.go Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you!

@github-actions github-actions bot added the Stale label Nov 29, 2023
@github-actions github-actions bot removed the Stale label Dec 1, 2023
asalzmann
asalzmann reviewed Dec 1, 2023
View reviewed changes
Copy link
Contributor

@asalzmann asalzmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverting UNDELEGATEHOST #935 looks great

For CALIBRATION #936, can you jog my memory on
(1) why remove the admin gate?
(2) why are we no longer blocking on ICAs?

x/stakeibc/keeper/icqcallbacks_callibrate_delegation.go Outdated Show resolved Hide resolved
x/stakeibc/keeper/icqcallbacks_delegator_shares_test.go Show resolved Hide resolved
x/stakeibc/keeper/icqcallbacks_callibrate_delegation.go Show resolved Hide resolved
sampocs
sampocs requested changes Dec 5, 2023
View reviewed changes
x/stakeibc/keeper/msg_server_submit_tx.go Outdated Show resolved Hide resolved
@sampocs sampocs added the v17 label Dec 6, 2023
sampocs
sampocs approved these changes Dec 6, 2023
View reviewed changes
Copy link
Collaborator

@sampocs sampocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

shellvish
shellvish approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@shellvish shellvish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thank you for doing this!

x/stakeibc/keeper/icqcallbacks_callibrate_delegation.go Show resolved Hide resolved
@riley-stride riley-stride merged commit 91a984a into main Dec 14, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asalzmann asalzmann asalzmann left review comments

@sampocs sampocs sampocs approved these changes

@shellvish shellvish shellvish approved these changes

Assignees
No one assigned
Labels
C:CLI C:proto C:stakeibc v17
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@riley-stride @asalzmann @sampocs @shellvish