Conversation
ocasta181
previously approved these changes
Jan 28, 2023
ocasta181
approved these changes
Jan 30, 2023
alcalawil
approved these changes
Jan 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wilfredo and I pair coded to move the docker-compose into infra, so that we can simultaneously debug the platform-admin-api and the main api at the same time if needed. The readme has been updated to include the commands required in order to run and debug in this manner. See other PR:
String-xyz/string-api#102
To test: (Instructions are now also included in readme.md in the main API)
You can run docker compose from any repo now, and it will compose string-api, platform-admin-api, postgres and redis.
Some initial sanitation: [do this from the infra repo]
cd localdocker compose downdocker system prune(/y)docker volume prune(/y)And then this can be run from any repo:
4)
docker compose -f ../infra/local/docker-compose.yml upYou should automatically get console output from whichever repo you run the previous command from. To get live console output from the other repo:
docker psto list the docker container namesdocker logs [docker container name] -fdocker logs platform-admin-api -fordocker logs string-api -ffrom a terminal in the repo you did not run the docker compose from