Conversation
* get user on refresh * improve error handling
* encode and decode nonce * delete test message * fix sign_test.go * Update api/handler/login.go Co-authored-by: Auroter <7332587+Auroter@users.noreply.github.com> * Update api/handler/user.go Co-authored-by: Auroter <7332587+Auroter@users.noreply.github.com> * minor fix * Update pkg/internal/common/sign_test.go Co-authored-by: Auroter <7332587+Auroter@users.noreply.github.com> Co-authored-by: Auroter <7332587+Auroter@users.noreply.github.com>
Co-authored-by: akfoster <andrin@string.xyz>
Co-authored-by: akfoster <andrin@string.xyz>
Co-authored-by: akfoster <andrin@string.xyz>
Co-authored-by: akfoster <andrin@string.xyz>
Task/sean/str 385
delete docker compose (we moved it to infra/local) and update readme …
Persist ALB DNS and Listener ARNs
* first pass at refactoring executor * abstract card payment steps * more cleanup * s to p * cleaned up errors * fixing bugs * working as expected * remove sign_test changes * revert card changes * Added more comments to postProcess and moved it closer to the top of transaction.go * Update pkg/service/transaction.go * close executor earlier * clean up executor calls --------- Co-authored-by: Sean <sean@string.xyz>
saito-sv
requested review from
alcalawil,
auroter,
frostbournesb and
ocasta181
and removed request for
alcalawil,
auroter and
ocasta181
auroter
previously approved these changes
Feb 13, 2023
alcalawil
previously approved these changes
Feb 13, 2023
* only a name change needed * cleanup of card creation and payment * set authorizeCharge to take transasctionProcessingData struct * move default cc back to success * simplify GetCardByFingerprint wrapper of GetWalletByAddr
ocasta181
temporarily deployed
to
development
GitHub Actions
Inactive
alcalawil
previously approved these changes
Feb 13, 2023
ocasta181
temporarily deployed
to
development
GitHub Actions
Inactive
* need a payment_code on transactions to associate with checkout payment * persist paymentCode after capture; we may not be able to immediately get action data * make chargeCard() use transactionProcessingData struct * cleanup * remove encodedMessage from sign_test.go * remove log
ocasta181
temporarily deployed
to
development
GitHub Actions
Inactive
alcalawil
approved these changes
Feb 14, 2023
ocasta181
approved these changes
Feb 14, 2023
auroter
approved these changes
Feb 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.