replace ioutil.ReadAll with io.ReadAll#122
Merged
Conversation
ocasta181
requested review from
alcalawil,
auroter,
frostbournesb and
saito-sv
frostbournesb
approved these changes
Feb 15, 2023
auroter
approved these changes
Feb 15, 2023
ocasta181
pushed a commit
that referenced
this pull request
Feb 23, 2023
ocasta181
pushed a commit
that referenced
this pull request
Feb 23, 2023
ocasta181
pushed a commit
that referenced
this pull request
Feb 24, 2023
* get instrument types sending properly again * remove CustomData and empty LocationData * Turns out they lied... * replace ioutil.ReadAll with io.ReadAll (#122) * fix go build on CI (#123) * fixed go build * Update .github/workflows/dev-deploy.yml * Update .github/workflows/dev-deploy.yml * use zero logs instead of log (#124) * merge conflicts * get instrument types sending properly again * remove CustomData and empty LocationData * Turns out they lied... * remove new lines * pull from master * replace ioutil.ReadAll with io.ReadAll (#122) * get instrument types sending properly again * Turns out they lied... * pull from master * allow nil device IPAddress * await unit21CreateInstrument * refactor unit21 for dependency injection; create wallet instrument on user creation --------- Co-authored-by: saito-sv <7920256+saito-sv@users.noreply.github.com> Co-authored-by: Sean <sean@string.xyz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that you can create a user, and execute a transaction without issue.