Skip to content

Fix/sean/quote payload float precision#133

Merged
auroter merged 3 commits intodevelopfrom
fix/sean/quotePayloadFloatPrecision
Mar 6, 2023
Merged

Fix/sean/quote payload float precision#133
auroter merged 3 commits intodevelopfrom
fix/sean/quotePayloadFloatPrecision

Conversation

@auroter
Copy link
Contributor

@auroter auroter commented Mar 4, 2023

To test:

Easy Test:

  1. Checkout and pull this branch
  2. Docker compose down, docker compose up
  3. Use Postman to get a quote
  4. Execute the quote

Expected behavior: The quote returns string values for the $ cost breakdown and the quote can be executed normally, returning a TX ID and TX URL.

Hard Test:

  1. Talk to me about how to test this in Unity. There are some dependencies that should be set locally instead of github, since they are not merged yet.

Expected Behavior: The Unity Demo executes transactions consistently using your metamask wallet.

@auroter auroter changed the base branch from main to develop March 4, 2023 00:12
saito-sv
saito-sv previously approved these changes Mar 6, 2023
Copy link

@saito-sv saito-sv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ocasta181
ocasta181 previously approved these changes Mar 6, 2023
@ocasta181 ocasta181 self-requested a review March 6, 2023 20:08
@ocasta181 ocasta181 dismissed their stale review March 6, 2023 20:08

accidental

@auroter auroter merged commit 180db6d into develop Mar 6, 2023
@auroter auroter deleted the fix/sean/quotePayloadFloatPrecision branch March 6, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants