Skip to content

STR-467 :: Make string-api use keys generated by platform-api#139

Merged
alcalawil merged 3 commits intodevelopfrom
task/wil/str-467
Mar 27, 2023
Merged

STR-467 :: Make string-api use keys generated by platform-api#139
alcalawil merged 3 commits intodevelopfrom
task/wil/str-467

Conversation

@alcalawil
Copy link
Contributor

@alcalawil alcalawil commented Mar 24, 2023

To test:

  1. In the string-api repo run go get github.com/String-xyz/go-lib@0f89042db8cbd38870872b7e789d39b6ae926240
  2. In the platform-admin-api repo on task/wil/str-467 run go get github.com/String-xyz/go-lib@0f89042db8cbd38870872b7e789d39b6ae926240
  3. docker-compose down && docker-compose up --build
  4. Create a Platform
  5. Create Api Key
  6. Authorize wallet using the created api key, in the string-sdk

frostbournesb
frostbournesb previously approved these changes Mar 24, 2023
ocasta181
ocasta181 previously approved these changes Mar 24, 2023
@alcalawil alcalawil dismissed stale reviews from ocasta181 and frostbournesb via 117259d March 24, 2023 21:53
ocasta181
ocasta181 previously approved these changes Mar 27, 2023
Copy link
Contributor

@ocasta181 ocasta181 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love to see so many lines removed :)

// PayloadToSign returns a payload to be sign by a wallet
// to authenticate an user, the payload expires in 15 minutes
PayloadToSign(walletAdress string) (SignablePayload, error)
PayloadToSign(walletAddress string) (SignablePayload, error)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!


// VerifySignedPayload receives a signed payload from the user and verifies the signature
// if signaure is valid it returns a JWT to authenticate the user
// if signature is valid it returns a JWT to authenticate the user
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another one!

@frostbournesb frostbournesb self-requested a review March 27, 2023 19:46
frostbournesb
frostbournesb previously approved these changes Mar 27, 2023
@alcalawil alcalawil merged commit 84a7b3f into develop Mar 27, 2023
@alcalawil alcalawil deleted the task/wil/str-467 branch March 27, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants