Merged
Conversation
…20 transfer events
…ution of multiple calls, added calls for NFT and Token Forwarding (not complete yet)
…cko always appeared to be down, fixed an issue with updating the timestamp of a cached token value even when failing to retrieve a new value
…ransact return body) and unit21
…d a bug where finding 0 tokens to forward for ERC721 or ERC20 reported an error, fixed a bug where forwards failed because they were using safeTransferFrom without an approve, added true max gas caching for each transaction request, fixed a bug where forwarding would be attempted when there was nothing to forward, added true gas summing including forwarding
frostbournesb
previously approved these changes
Jul 13, 2023
ocasta181
approved these changes
Jul 17, 2023
saito-sv
approved these changes
Jul 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To test:
The original estimate is not able to account for any actions simulated after Approve(), because the commands being simulated do not sequentially maintain state. Therefore if you simulate Approve() and then Swap(), the Swap() simulation will fail because the current status of the real blockchain does not include the Approve().
The reasoning above is why you should expect the gas estimate to scale by a factor of ~3 after executing the transaction once - because the original estimate did not account for the Approve() or the Forwarding of the asset (Transfer()) from the API back to the end user.