Skip to content

remove https from base url in .env.example #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
brianspierce merged 1 commit into from
Jul 23, 2023
Merged

remove https from base url in .env.example #236

brianspierce merged 1 commit into from
Jul 23, 2023

Conversation

@brianspierce
Copy link

@brianspierce brianspierce commented Jul 20, 2023

Changes:

  • When including https, it causes an SSL error when clicking the "verify email" link.
  • Also, added env config to TestEncryptDecryptKMS function to allow connection to AWS.

To Test:

  • Send a "verify email" and successfully click the link
  • Run TestEncryptDecryptKMS successfully

@brianspierce brianspierce merged commit 617696c into develop Jul 23, 2023
@brianspierce brianspierce deleted the fix/brian/env-fix branch July 23, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ocasta181 ocasta181 ocasta181 approved these changes

@auroter auroter Awaiting requested review from auroter

@saito-sv saito-sv Awaiting requested review from saito-sv

+1 more reviewer

@frostbournesb frostbournesb frostbournesb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@brianspierce @ocasta181 @frostbournesb