Skip to content

v1.0.0-alpha #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
saito-sv merged 432 commits into from
Jan 10, 2023
Merged

v1.0.0-alpha #70

saito-sv merged 432 commits into from
Jan 10, 2023

Conversation

@saito-sv
Copy link

@saito-sv saito-sv commented Jan 5, 2023

No description provided.

Auroter and others added 30 commits November 1, 2022 15:26
added StringArray
e783dce
Allow email verification without protection
192419e
remove base / in /user/
131b42c
@auroter
Merge pull request #18 from String-xyz/task/sean/str-94
38d4528 
Task/sean/str 94
update email URL with unprotected endpoint
f5be2bc
@auroter
Merge pull request #19 from String-xyz/hotfix/email-url
e03c391 
update email URL with unprotected endpoint
@ocasta181
move out repos into own struct
4950730
@ocasta181
fix quote typo
3c1982b
@ocasta181
remove todo comment from entity model
e6be36e
@ocasta181
resolve merge conflicts
2e16357
@ocasta181
GetId to GetById
3b201c9
USE CORS!
fc8af93
@auroter
Merge pull request #20 from String-xyz/hotfix/CORS
e4e0807 
USE CORS!
@ocasta181
ensure verification endpoint is properly routed
638243e
Merge pull request #14 from String-xyz/task/andrin/str-154
beb2d7c 
Task/andrin/str 154
@ocasta181
have transaction and instrument tests working better; initial work on…
0bb3708 
… integrating into service layer
@ocasta181
more progress, stuck on entity create
3ffb77c
@ocasta181
add location_test, remove some old TODOs
e7f0b25
@ocasta181
pass userId to transact and handle
a009048
Get last 4 and unique card instrument ID for TX legs
898f8e1
updated login/register
70adfe8
Made email verification/login use GET instead of POST since they are …
45449a2 
…accessed from browser url
fixed a bug where Checkout Instrument ID (str_3940293403) was passed …
5d22e48 
…into TX Leg Instrument UUID
@saito-sv
STR-182 (#17)
a43d80d 
* WIP

* auth_key

* handler

* tested all endpoints

* infra

* updated stub and removed logs
@saito-sv
fixed makefile (#22)
60adb06
Use checkout instrument fingerprint because it's unique
aab56f5
@saito-sv
alb should be on private subnet (#23)
dac5dd0
Make sure base64 login codes are html safe
17ad663
verify userId is valid before attempting to transact
3a7cb3e
@ocasta181
get unit21 transaction data connected to execute tx, also getting log…
4221e9b 
…in link working
Sean and others added 15 commits January 9, 2023 13:49
Added message to beginning of WalletAuthenticationPayload, then dealt…
6afbe28 
… with that being signed in addition to the nonce suffix
re-enable API key protection
1018e8b
shorten logic
63c81b7
added a space between message and nonce
65ccdec
@alcalawil
respond 409 when user email is already validated (#75)
324ed6a
now with newlines!
f938dbe
stop throwing stringerror if fingerprint doesn't provide a subdivisio…
68e3447 
…n (state)
@auroter
Merge pull request #77 from String-xyz/task/sean/fixFingerprint
db764f1 
stop throwing stringerror if fingerprint doesn't provide a subdivisio…
Update service fee floor to $0.30
d683f81
change string fee to 3%
d9f0b7f
@ocasta181
small changes to fee + more comments
d06738d
@auroter
Merge pull request #78 from String-xyz/task/sean/priceFloor
8bae94a 
Update service fee floor to $0.30
punctuation
68f7b06
@auroter
Merge pull request #76 from String-xyz/task/sean/str-249
2d43900 
Task/sean/str 249
@saito-sv
admin api infra (#79)
d7d1f51
@saito-sv saito-sv changed the title v1.0.0-alpha v1.0.0.0-alpha Jan 10, 2023
@saito-sv saito-sv changed the title v1.0.0.0-alpha v1.0.0-alpha Jan 10, 2023
ocasta181
ocasta181 previously approved these changes Jan 10, 2023
View reviewed changes
saito-sv
saito-sv commented Jan 10, 2023
View reviewed changes
saito-sv
saito-sv commented Jan 10, 2023
View reviewed changes
auroter
auroter previously approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@auroter auroter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@saito-sv saito-sv dismissed stale reviews from auroter and ocasta181 via 9c7ecc1 January 10, 2023 19:16
@saito-sv saito-sv requested review from auroter and ocasta181 January 10, 2023 19:20
auroter
auroter approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@auroter auroter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, all that changed since my last review was the version #.

@saito-sv saito-sv merged commit 3cc49ba into main Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ocasta181 ocasta181 ocasta181 approved these changes

@frostbournesb frostbournesb Awaiting requested review from frostbournesb

+2 more reviewers

@auroter auroter auroter approved these changes

@alcalawil alcalawil alcalawil approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@saito-sv @ocasta181 @auroter @alcalawil @frostbournesb