Skip to content

Allow Last4 to be included when creating an Instrument in the DB#92

Merged
auroter merged 1 commit intodevelopfrom
task/sean/fix_last4
Jan 13, 2023
Merged

Allow Last4 to be included when creating an Instrument in the DB#92
auroter merged 1 commit intodevelopfrom
task/sean/fix_last4

Conversation

@auroter
Copy link
Contributor

@auroter auroter commented Jan 13, 2023

To test this:

  1. Docker Up
  2. Comment out line 27 on pkg/service/auth.go
  3. Comment in line 25 on pkg/service/auth.go
  4. Get a Wallet Authentication Payload in Insomnia and Create a User
  5. Log in for posterity
  6. Quote and Transact
  7. The test Credit Card instrument in the Instrument table will now include the last 4 digits:
    image

@auroter auroter changed the base branch from main to develop January 13, 2023 19:06
alcalawil
alcalawil approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@alcalawil alcalawil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

LGTM

@auroter auroter merged commit e8885f2 into develop Jan 13, 2023
@auroter auroter deleted the task/sean/fix_last4 branch January 13, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ocasta181 ocasta181 ocasta181 approved these changes

@frostbournesb frostbournesb Awaiting requested review from frostbournesb

@saito-sv saito-sv Awaiting requested review from saito-sv

+1 more reviewer

@alcalawil alcalawil alcalawil approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@auroter @ocasta181 @alcalawil