[STR-530] Allow platform to set env#32
Merged
frostbournesb merged 6 commits intodevelopfrom Apr 4, 2023
Merged
Conversation
ocasta181
previously approved these changes
Apr 4, 2023
alcalawil
reviewed
Apr 4, 2023
| { name: 'LOCAL_API_URL', value: process.env.LOCAL_API_URL }, | ||
| ] | ||
|
|
||
| for (const env of ENV_TABLE) { |
alcalawil
approved these changes
Apr 4, 2023
ocasta181
approved these changes
Apr 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes:
All the env vars must be present to bundle, copy over .env.example exactly.
apiKey no longer goes into the payload, the iframe does nothing with it so it does not belong in payload, it has been renamed to publicKey since secret keys are in the works, now the user will pass the publicKey to the init function onmount, this puts it more in line with checkout's SDK.
the VITE_ANALYTICS_SUBDOMAIN_URL env var is used now
the services were rearchitected slightly to accommodate
In src/routes/+page.svelte:35
Criteria: All envs (save untestable prod) with their respective api keys work as expected without even needing to rebundle.