move 'action' logic out of events service#45
Closed
Conversation
alcalawil
reviewed
Jun 7, 2023
| @@ -1,18 +1,16 @@ | |||
| import type { ApiClient, User } from './apiClient.service'; | |||
| import type { ApiClient, User, UserUpdate } from "./apiClient.service"; | |||
Contributor
There was a problem hiding this comment.
@frostbournesb @saito-sv @ocasta181 Let's agree on this and we can set the linter on all of the projects. Single or double quotes?
Contributor
There was a problem hiding this comment.
I would say single is easier to type but do not have a strong preference
alcalawil
reviewed
Jun 7, 2023
src/lib/services/auth.service.ts
Outdated
| } | ||
| }, 5000); | ||
| } catch (error: any){ | ||
| return error |
Contributor
There was a problem hiding this comment.
do not return an error, let's throw it back to the caller.
Contributor
|
these changes were merged in #47 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
To Test