-
Notifications
You must be signed in to change notification settings - Fork 1
decouple sdk from svelte #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clean get rid of rollup.js fixes
b4b9a8b to
03477b3
Compare
saito-sv
previously approved these changes
Jul 4, 2023
This was referenced Jul 8, 2023
ocasta181
reviewed
Jul 8, 2023
ocasta181
reviewed
Jul 8, 2023
ocasta181
reviewed
Jul 8, 2023
ocasta181
reviewed
Jul 8, 2023
| "esModuleInterop": true, | ||
| "forceConsistentCasingInFileNames": true, | ||
| "resolveJsonModule": true, | ||
| // "resolveJsonModule": true, |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be removed?
ocasta181
reviewed
Jul 8, 2023
ocasta181
approved these changes
Jul 9, 2023
frostbournesb
approved these changes
Jul 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to test
task/wil/str-653task/andrin/str-653task/wil/str-653string-api,dashboard-api, anddashboard-appon developstring-sdk:a. be sure you have the up to date env vars!
b. un
yarn; yarn bundlec. Copy the contents of the
./distinto a new folder./dist_1d. Create a new
package.jsonfile in the./dist_1folder (use the code attached below)e. from ./dist_1 run
yarn linkpayment-appa. make sure to have the necessary env variables
b. run
yarn; yarn devpayment-app-examplea. set your wallet address and api key in
.envb. run
yarn link @stringpay/sdkc. run
yarn; yarn dev