Skip to content

Conversation

HDBandit
Copy link

@HDBandit HDBandit commented Jul 1, 2022

Jira Ticket

Example-ticket-to-be-replaced

Implementation details

This branch contains the last changes from Grapphopper remote repository (master branch). It also should contain the last changes from Graphhopper Matrix repository (develop branch).

This branch should be merged once Graphhopper releases a new official version, not before.

Examples

NA

Testing

Test passing CI.

@HDBandit HDBandit changed the title Continuous Integration with GH remote. ⚠️ Not merge until official tag released !!! ⚠️ Last changes GH remote. ⚠️ Not merge until official tag released !!! ⚠️ Jul 1, 2022
@HDBandit HDBandit closed this Jul 1, 2022
@HDBandit HDBandit reopened this Jul 1, 2022
easbar and others added 27 commits August 29, 2022 22:58
Fix compilation error
* Support ";" access delimiter for car access.
One example is motor_vehicle = agricultural;forestry

* Add support for ";" access delimiter for MotorcycleTagParser and road_access EV.

* Move logic for access delimiter handling for ";" from RoadAccess into OSMRoadAccessParser

* Fix for OSMRoadAccessParserTest
karussell and others added 29 commits March 1, 2023 15:43
…er#2742

* the intervals are only really needed for the simplification, so create them there
* use custom weighting, since this should be most common now
* algorithm should not matter (this is tested elsewhere)
* Update snapped point when changing the closest node

* update wayindex and position too

* update query distance too

---------

Co-authored-by: easbar <easbar.mail@posteo.net>
Co-authored-by: Thomas Butz <thomas.butz@optitool.de>
* Pass all node tags to edge handlers

* Remove node tag count (was only used for analysis)

* crossing EV (graphhopper#2706)

* add tests; fix traffic_signalS; remove zebra as same as uncontrolled; include proposed tags https://wiki.openstreetmap.org/wiki/Proposed_features/Highway_crossing_cleanup

* fix

* fix tests

* minor fix

* minor typo

* node tag whitelist; use get not put in removeTag

* include node tags handling for road_access and fords (road_environment)

* mark only node tags of barrier edge as 'split_node'

* avoid stream and collect

* minor further perf tune

* make barrier edge explicit via tag

* simplify handleNodeTags

* Remove artificial gh:split_node tag and use long hash set instead

* minor rename

* use EdgeKVStorage for node tags storage

* rename EdgeKVStorage to KVStorage as also used to temporarily store node tags for import

* log more infos about node tags; no compact necessary due to KVStorage; limit pointer of KVStorage to positive numbers for now

* rename method to handleBarrierEdge

* fix taggednodecount method

* node tags for the barrier edge should be identical, i.e. use the ref instead of a copy

---------

Co-authored-by: Peter <graphhopper@gmx.de>
* initial backward_car_access impl

* test+fix when used in CustomModel
…raphhopper#2774)

* bike: allow reverse oneways; mark them as 'get off bike' and slow down to 4km/h

* fix speed issue

* fix test

* create bike_oneway that is always true, except for the reverse direction of a oneway road

* fix tests

* minor cleanup

* initial backward_car_access impl

* test+fix when used in CustomModel

* use modified bike profile

* include custom_models/bike.json in integration test

* for bike test reverse access of oneways; use jackson allow comments feature

* revert changes to jackson parsing with comment

* include bike_priority in bike.json

* make custom models simpler via setting bike speed and priority unconditionally at the beginning

* add get_off_bike parser after bike_access

* comment

* fixed typo

* re-add test

* imports

* minor revert to master for 2 files
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 529 Code Smells

No Coverage information No Coverage information
2.1% 2.1% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

9 participants