Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch requests #21

Merged
merged 3 commits into from
Sep 16, 2019
Merged

Patch requests #21

merged 3 commits into from
Sep 16, 2019

Conversation

jaimeiniesta
Copy link
Contributor

Adds support for PATCH requests, needed to update jobs:

https://stuart.api-docs.io/v2/jobs/update-a-job

seanhandley
seanhandley approved these changes Aug 9, 2019
View reviewed changes
Copy link
Contributor

@seanhandley seanhandley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Not sure about the hardcoding of values in the specs, though. In RSpec I'd use a let for these, but perhaps here they could be module attributes? Or maybe even something else? WDYT?

test/stuart_client_elixir/http_client_test.exs Outdated
#####################
# Private functions #
#####################

defp response(:get, "https://sandbox-api.stuart.com/timeout") do
defp response(_, "https://sandbox-api.stuart.com/timeout") do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sandbox URL seems like a good candidate for a module attribute.

@jaimeiniesta jaimeiniesta merged commit 248497c into develop Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanhandley seanhandley seanhandley approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaimeiniesta @seanhandley