Pretty-prints GitHub Release webhooks inside Discord #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyndsiWilliams
approved these changes
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Discords GitHub Webhook handling is… fine.
I've updated it to not just show the new version number, but changelog and direct links to the download as well.
Instead of going
we now go
and the added endpoint
/webhooktakes care of convertingrelease.publishedmessages to Discord embeds and forwarding that to Discord.Added a test for the conversion as well.
(For some reason we were running Node.js 20 but the package.json wasn't up to date; remedied that.)
Before/after screenshots and/or animated gif
Before
After
Testing instructions
Push a commit prefixed with
feat:,fix:,feat!:orfix!:to the game repository's default branch and that message should make it's way to Discord.Additional information
[ ]Changes UI[ ]Has associated resource: