Add support for configuring a front and back cover page for PDFs #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify utils deep_merge! (not using block form) Add middleware specs to test cover page request/merging Add utils specs for new helper methods Add accessor specs for grover cover page configs Updated README with info on how to use cover pages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because Puppeteer doesn't allow for the header/footer to be configured 'per page' on a programatic basis, instead we'll try overcome this by allowing the response PDF to have a specified page (or pages) added to the front and back.
The specified path will be requested via the middleware (to the downstream app) using the same request method/body as the original request, but will override the path/params with those specified in the
front_cover_pathandback_cover_pathparameters.These parameters can be configured in the global options or via meta tags in the original downstream response.