Skip to content

Commit

Permalink
Merge branch 'fix-build'
Browse files Browse the repository at this point in the history
  • Loading branch information
Stuk committed Aug 5, 2021
2 parents e5b3f0d + e08003e commit 5639745
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 10 deletions.
5 changes: 3 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
*~
.c9revisions
.DS_Store
node_modules
sauce_connect.log
.c9revisions
sauce_connect.log
14 changes: 8 additions & 6 deletions documentation/contributing.md
Original file line number Diff line number Diff line change
Expand Up @@ -63,12 +63,14 @@ If you have tested bug fixes or new features, you can open a

## Releasing a new version

1. Run `npm test`
1. In `package.json` temporarily change `"./lib/index"` to `"."`
2. Run `npm test`
* Locally open http://localhost:8080/test/
* Or use the SauceLabs configuration above
2. Update `JSZip.version` in `index.js` and in `package.json`
3. Run `grunt` to generate the new dist files
3. Update `JSZip.version` in `index.js` and in `package.json`
4. Run `grunt` to generate the new dist files
* undo the package.json change, it was just needed to replace the `__VERSION__` in the header
4. Update CHANGES.md
5. Run `npm version ...` where `...` is `major`, `minor`, or `patch`
6. Run npm publish
5. Undo step 1.
6. Update CHANGES.md
7. Run `npm version ...` where `...` is `major`, `minor`, or `patch`
8. Run npm publish
3 changes: 1 addition & 2 deletions test/asserts/load.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@ QUnit.module("load", function () {
assert.ok(typeof file === "string");
JSZip.loadAsync(file)
.then(function (zip) {
// Passes in Node, fails in browsers:
// assert.equal(Object.getPrototypeOf(zip.files), zip.files.__proto__); // jshint ignore:line
assert.notEqual(Object.getPrototypeOf(zip.files), zip.files.__proto__); // jshint ignore:line
return zip.file("__proto__").async("string"); })
.then(function(result) {
assert.equal(result, "hello\n", "the zip was correctly read.");
Expand Down

0 comments on commit 5639745

Please sign in to comment.