change the grunt config for the issue #80 #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use "/*!" to ensure attribution comment is preserved by minifiers
…bert-patch-1 Conflicts: jszip.js
This commit updates the grunt configuration to ensure that the license comment (starting with /*! for the minifiers) makes its way to the final dist files.
| Dual licenced under the MIT license or GPLv3. See https://raw.github.com/Stuk/jszip/master/LICENSE.markdown. | ||
| */ | ||
| /** | ||
| Usage: |
There was a problem hiding this comment.
This part is more docs than license, so IMHO it doesn't make sense to have it in license_header.js.
There was a problem hiding this comment.
You're right, I moved too many lines
dduponchel
added a commit
that referenced
this pull request
Feb 1, 2014
change the grunt config for the issue #80
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the switch to grunt/browserify/uglify, the fix in #80 no longer works. This pull request reuses the commit in #80 and updates the grunt configuration to ensure that the license comment (starting with /*! for the minifiers) makes its way to the final dist files.