generated from StuyPulse/Phil
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable unused spark max status frames #55
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anivanchen
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine.
BenG49
added a commit
that referenced
this pull request
Mar 4, 2024
* Update camera names to be more descriptive * Random refactors * Add reverse bind on operator controller * Add lift to driver manual score amp * Disable unused spark max status frames (#55) * Disable status frames * Combine max and flex configurations into spark base * Log swerve drive current * Downgrade revlib * Fix auton speaker alignment mirroring * Add gandalf to amp and to shooter commands * Re zero front right swerve * Increase controller buzz * Controls changes + fixes * Use all tags for amp alignment * Make intake leds flash white * Comment out shooter differential changing sides * Change CBAE path * Increase shooter speeds * Make shooterspeeds accept smart number * Increase podium shot distance * Increase amp setup distance, undo podium shot distance increase * Split blay 5 piece auto and previous 5 piece auto * Change disable status frame time to 500ms * Retune shooter + shot distance * Intake swap to vortex * Datalog defaults * Remove intake current limit * Port forward cameras while tethered * Remove current limits on rollers * Chaagne shooter settings agani * Redo path mirroring * Fix rotation path mirroring * Timeout wait for shooter, leds purple if interrupted * Add back operator bind * Remove has shot check * Increase auto shoot time * Log to shoot target angle * Rainbow * Fix CBAE auto maybe (untested) * Fix SwerveDriveToShoot * Lower shoot distance * Add pixel coordinate reading from cameras * Re-change shoot distance * Retune four piece first pickup, bring back distance * Decrease angle stddevs, disable intake camera while aligning amp * Undo vision/odometry changes * Lower auton shooting time * Update first piece pickup in 3.5 HGF * Increase shoot time again * Move hgf first piece intake * Add driver reset odometry binds * Add auton align timeout * Clean button bindings * Clean SwerveDriveToShoot * Clean followPathCommand * Turn off path flipping for autobuilder --------- Co-authored-by: Prog694 <prog692@gmail.com> Co-authored-by: BenG49 <64862590+BenG49@users.noreply.github.com> Co-authored-by: BenG49 <ben@goldfisher.com>
BenG49
added a commit
that referenced
this pull request
Mar 5, 2024
* Update camera names to be more descriptive * Random refactors * Add reverse bind on operator controller * Add lift to driver manual score amp * Disable unused spark max status frames (#55) * Disable status frames * Combine max and flex configurations into spark base * Log swerve drive current * Downgrade revlib * Fix auton speaker alignment mirroring * Add gandalf to amp and to shooter commands * Re zero front right swerve * Increase controller buzz * Controls changes + fixes * Use all tags for amp alignment * Make intake leds flash white * Comment out shooter differential changing sides * Change CBAE path * Increase shooter speeds * Make shooterspeeds accept smart number * Increase podium shot distance * Increase amp setup distance, undo podium shot distance increase * Split blay 5 piece auto and previous 5 piece auto * Change disable status frame time to 500ms * Retune shooter + shot distance * Intake swap to vortex * Datalog defaults * Remove intake current limit * Port forward cameras while tethered * Remove current limits on rollers * Chaagne shooter settings agani * Redo path mirroring * Fix rotation path mirroring * Timeout wait for shooter, leds purple if interrupted * Add back operator bind * Remove has shot check * Increase auto shoot time * Log to shoot target angle * Rainbow * Fix CBAE auto maybe (untested) * Fix SwerveDriveToShoot * Lower shoot distance * Add pixel coordinate reading from cameras * Re-change shoot distance * Retune four piece first pickup, bring back distance * Decrease angle stddevs, disable intake camera while aligning amp * Undo vision/odometry changes * Lower auton shooting time * Update first piece pickup in 3.5 HGF * Increase shoot time again * Move hgf first piece intake * Add driver reset odometry binds * Add auton align timeout * Merged conveyor into intake subsystem. Fixed commands to use Intake methods instead. (shooter subsystem still needs to be corrected by shooter group, so theres still errors there) * Rename motor configs * Fix some build errors * Fix spacing * Fix more spacing * More formatting fixes * Se/shooter remake (#60) * Directions for shooter changes * Change to patriot shooter Co-authored-by: alex <alex-wanger@users.noreply.github.com> Co-authored-by: ilovemarmot <Traceylin023@users.noreply.github.com> Co-authored-by: Ardian Agoes <ardianagoes@users.noreply.github.com> Co-authored-by: Colyi <colyic@users.noreply.github.com> * Add shooter handoff shot * Remove shooter IR ports --------- Co-authored-by: alex <alex-wanger@users.noreply.github.com> Co-authored-by: ilovemarmot <Traceylin023@users.noreply.github.com> Co-authored-by: Ardian Agoes <ardianagoes@users.noreply.github.com> Co-authored-by: Colyi <colyic@users.noreply.github.com> Co-authored-by: BenG49 <ben@goldfisher.com> Co-authored-by: BenG49 <64862590+BenG49@users.noreply.github.com> --------- Co-authored-by: Ivan Chen <ivanchen07@gmail.com> Co-authored-by: Prog694 <prog692@gmail.com> Co-authored-by: Ian Shi <Ianshi1026@gmail.com> Co-authored-by: ambers7 <95728455+ambers7@users.noreply.github.com> Co-authored-by: alex <alex-wanger@users.noreply.github.com> Co-authored-by: ilovemarmot <Traceylin023@users.noreply.github.com> Co-authored-by: Ardian Agoes <ardianagoes@users.noreply.github.com> Co-authored-by: Colyi <colyic@users.noreply.github.com>
BenG49
added a commit
that referenced
this pull request
Mar 5, 2024
* Update camera names to be more descriptive * Random refactors * Add reverse bind on operator controller * Add lift to driver manual score amp * Disable unused spark max status frames (#55) * Disable status frames * Combine max and flex configurations into spark base * Log swerve drive current * Downgrade revlib * Fix auton speaker alignment mirroring * Add gandalf to amp and to shooter commands * Re zero front right swerve * Increase controller buzz * Controls changes + fixes * Use all tags for amp alignment * Make intake leds flash white * Comment out shooter differential changing sides * Change CBAE path * Increase shooter speeds * Make shooterspeeds accept smart number * Increase podium shot distance * Increase amp setup distance, undo podium shot distance increase * Split blay 5 piece auto and previous 5 piece auto * Change disable status frame time to 500ms * Retune shooter + shot distance * Intake swap to vortex * Datalog defaults * Remove intake current limit * Port forward cameras while tethered * Remove current limits on rollers * Chaagne shooter settings agani * Redo path mirroring * Fix rotation path mirroring * Timeout wait for shooter, leds purple if interrupted * Add back operator bind * Remove has shot check * Increase auto shoot time * Log to shoot target angle * Rainbow * Fix CBAE auto maybe (untested) * Fix SwerveDriveToShoot * Lower shoot distance * Add pixel coordinate reading from cameras * Re-change shoot distance * Retune four piece first pickup, bring back distance * Decrease angle stddevs, disable intake camera while aligning amp * Undo vision/odometry changes * Lower auton shooting time * Update first piece pickup in 3.5 HGF * Increase shoot time again * Move hgf first piece intake * Add driver reset odometry binds * Add auton align timeout * add FilteredRelativeEncoder Co-authored-by: simon <szhu70@users.noreply.github.com> Co-authored-by: Owen-Zeng <Owen-Zeng@users.noreply.github.com> Co-authored-by: mabdullah32 <mabdullah32@users.noreply.github.com> Co-authored-by: Rahuldeb75 <Rahuldeb75@users.noreply.github.com> Co-authored-by: metereel <Material-Energy@users.noreply.github.com> Co-authored-by: BrianZ60 <BrianZ60@users.noreply.github.com> Co-authored-by: rzheng287 <rzheng287@users.noreply.github.com> Co-authored-by: urnotkool <urnotkool@users.noreply.github.com> * Switched all encoder initalizations with FilteredRelativeEncoder, correct filter encoder getter methods Co-authored-by: simon <szhu70@users.noreply.github.com> Co-authored-by: urnotkool <urnotkool@users.noreply.github.com> Co-authored-by: Rahuldeb75 <Rahuldeb75@users.noreply.github.com> Co-authored-by: rzheng287 <rzheng287@users.noreply.github.com> Co-authored-by: BrianZ60 <BrianZ60@users.noreply.github.com> Co-authored-by: Owen-Zeng <Owen-Zeng@users.noreply.github.com> * remove stupid filter * Update AmperImpl.java * Update SwerveModuleImpl.java * Fix get position logic * Keep drive encoder as relative encoder type --------- Co-authored-by: Ivan Chen <ivanchen07@gmail.com> Co-authored-by: Prog694 <prog692@gmail.com> Co-authored-by: BenG49 <64862590+BenG49@users.noreply.github.com> Co-authored-by: BenG49 <ben@goldfisher.com> Co-authored-by: simon <szhu70@users.noreply.github.com> Co-authored-by: Owen-Zeng <Owen-Zeng@users.noreply.github.com> Co-authored-by: mabdullah32 <mabdullah32@users.noreply.github.com> Co-authored-by: Rahuldeb75 <Rahuldeb75@users.noreply.github.com> Co-authored-by: metereel <Material-Energy@users.noreply.github.com> Co-authored-by: BrianZ60 <BrianZ60@users.noreply.github.com> Co-authored-by: rzheng287 <rzheng287@users.noreply.github.com> Co-authored-by: urnotkool <urnotkool@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also combine spark flex and spark max motor configs