Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable unused spark max status frames #55

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Conversation

BenG49
Copy link
Contributor

@BenG49 BenG49 commented Feb 27, 2024

also combine spark flex and spark max motor configs

@BenG49 BenG49 requested review from selym3 and anivanchen February 27, 2024 17:59
Copy link
Member

@anivanchen anivanchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine.

@BenG49 BenG49 changed the base branch from main to robot/soflo February 29, 2024 17:14
@BenG49 BenG49 merged commit 7c7a150 into robot/soflo Feb 29, 2024
1 check passed
@BenG49 BenG49 deleted the bg/disable-status-frames branch February 29, 2024 17:14
BenG49 added a commit that referenced this pull request Mar 4, 2024
* Update camera names to be more descriptive

* Random refactors

* Add reverse bind on operator controller

* Add lift to driver manual score amp

* Disable unused spark max status frames (#55)

* Disable status frames

* Combine max and flex configurations into spark base

* Log swerve drive current

* Downgrade revlib

* Fix auton speaker alignment mirroring

* Add gandalf to amp and to shooter commands

* Re zero front right swerve

* Increase controller buzz

* Controls changes + fixes

* Use all tags for amp alignment

* Make intake leds flash white

* Comment out shooter differential changing sides

* Change CBAE path

* Increase shooter speeds

* Make shooterspeeds accept smart number

* Increase podium shot distance

* Increase amp setup distance, undo podium shot distance increase

* Split blay 5 piece auto and previous 5 piece auto

* Change disable status frame time to 500ms

* Retune shooter + shot distance

* Intake swap to vortex

* Datalog defaults

* Remove intake current limit

* Port forward cameras while tethered

* Remove current limits on rollers

* Chaagne shooter settings agani

* Redo path mirroring

* Fix rotation path mirroring

* Timeout wait for shooter, leds purple if interrupted

* Add back operator bind

* Remove has shot check

* Increase auto shoot time

* Log to shoot target angle

* Rainbow

* Fix CBAE auto maybe (untested)

* Fix SwerveDriveToShoot

* Lower shoot distance

* Add pixel coordinate reading from cameras

* Re-change shoot distance

* Retune four piece first pickup, bring back distance

* Decrease angle stddevs, disable intake camera while aligning amp

* Undo vision/odometry changes

* Lower auton shooting time

* Update first piece pickup in 3.5 HGF

* Increase shoot time again

* Move hgf first piece intake

* Add driver reset odometry binds

* Add auton align timeout

* Clean button bindings

* Clean SwerveDriveToShoot

* Clean followPathCommand

* Turn off path flipping for autobuilder

---------

Co-authored-by: Prog694 <prog692@gmail.com>
Co-authored-by: BenG49 <64862590+BenG49@users.noreply.github.com>
Co-authored-by: BenG49 <ben@goldfisher.com>
BenG49 added a commit that referenced this pull request Mar 5, 2024
* Update camera names to be more descriptive

* Random refactors

* Add reverse bind on operator controller

* Add lift to driver manual score amp

* Disable unused spark max status frames (#55)

* Disable status frames

* Combine max and flex configurations into spark base

* Log swerve drive current

* Downgrade revlib

* Fix auton speaker alignment mirroring

* Add gandalf to amp and to shooter commands

* Re zero front right swerve

* Increase controller buzz

* Controls changes + fixes

* Use all tags for amp alignment

* Make intake leds flash white

* Comment out shooter differential changing sides

* Change CBAE path

* Increase shooter speeds

* Make shooterspeeds accept smart number

* Increase podium shot distance

* Increase amp setup distance, undo podium shot distance increase

* Split blay 5 piece auto and previous 5 piece auto

* Change disable status frame time to 500ms

* Retune shooter + shot distance

* Intake swap to vortex

* Datalog defaults

* Remove intake current limit

* Port forward cameras while tethered

* Remove current limits on rollers

* Chaagne shooter settings agani

* Redo path mirroring

* Fix rotation path mirroring

* Timeout wait for shooter, leds purple if interrupted

* Add back operator bind

* Remove has shot check

* Increase auto shoot time

* Log to shoot target angle

* Rainbow

* Fix CBAE auto maybe (untested)

* Fix SwerveDriveToShoot

* Lower shoot distance

* Add pixel coordinate reading from cameras

* Re-change shoot distance

* Retune four piece first pickup, bring back distance

* Decrease angle stddevs, disable intake camera while aligning amp

* Undo vision/odometry changes

* Lower auton shooting time

* Update first piece pickup in 3.5 HGF

* Increase shoot time again

* Move hgf first piece intake

* Add driver reset odometry binds

* Add auton align timeout

* Merged conveyor into intake subsystem. Fixed commands to use Intake methods instead. (shooter subsystem still needs to be corrected by shooter group, so theres still errors there)

* Rename motor configs

* Fix some build errors

* Fix spacing

* Fix more spacing

* More formatting fixes

* Se/shooter remake (#60)

* Directions for shooter changes

* Change to patriot shooter

Co-authored-by: alex <alex-wanger@users.noreply.github.com>
Co-authored-by: ilovemarmot <Traceylin023@users.noreply.github.com>
Co-authored-by: Ardian Agoes <ardianagoes@users.noreply.github.com>
Co-authored-by: Colyi <colyic@users.noreply.github.com>

* Add shooter handoff shot

* Remove shooter IR ports

---------

Co-authored-by: alex <alex-wanger@users.noreply.github.com>
Co-authored-by: ilovemarmot <Traceylin023@users.noreply.github.com>
Co-authored-by: Ardian Agoes <ardianagoes@users.noreply.github.com>
Co-authored-by: Colyi <colyic@users.noreply.github.com>
Co-authored-by: BenG49 <ben@goldfisher.com>
Co-authored-by: BenG49 <64862590+BenG49@users.noreply.github.com>

---------

Co-authored-by: Ivan Chen <ivanchen07@gmail.com>
Co-authored-by: Prog694 <prog692@gmail.com>
Co-authored-by: Ian Shi <Ianshi1026@gmail.com>
Co-authored-by: ambers7 <95728455+ambers7@users.noreply.github.com>
Co-authored-by: alex <alex-wanger@users.noreply.github.com>
Co-authored-by: ilovemarmot <Traceylin023@users.noreply.github.com>
Co-authored-by: Ardian Agoes <ardianagoes@users.noreply.github.com>
Co-authored-by: Colyi <colyic@users.noreply.github.com>
BenG49 added a commit that referenced this pull request Mar 5, 2024
* Update camera names to be more descriptive

* Random refactors

* Add reverse bind on operator controller

* Add lift to driver manual score amp

* Disable unused spark max status frames (#55)

* Disable status frames

* Combine max and flex configurations into spark base

* Log swerve drive current

* Downgrade revlib

* Fix auton speaker alignment mirroring

* Add gandalf to amp and to shooter commands

* Re zero front right swerve

* Increase controller buzz

* Controls changes + fixes

* Use all tags for amp alignment

* Make intake leds flash white

* Comment out shooter differential changing sides

* Change CBAE path

* Increase shooter speeds

* Make shooterspeeds accept smart number

* Increase podium shot distance

* Increase amp setup distance, undo podium shot distance increase

* Split blay 5 piece auto and previous 5 piece auto

* Change disable status frame time to 500ms

* Retune shooter + shot distance

* Intake swap to vortex

* Datalog defaults

* Remove intake current limit

* Port forward cameras while tethered

* Remove current limits on rollers

* Chaagne shooter settings agani

* Redo path mirroring

* Fix rotation path mirroring

* Timeout wait for shooter, leds purple if interrupted

* Add back operator bind

* Remove has shot check

* Increase auto shoot time

* Log to shoot target angle

* Rainbow

* Fix CBAE auto maybe (untested)

* Fix SwerveDriveToShoot

* Lower shoot distance

* Add pixel coordinate reading from cameras

* Re-change shoot distance

* Retune four piece first pickup, bring back distance

* Decrease angle stddevs, disable intake camera while aligning amp

* Undo vision/odometry changes

* Lower auton shooting time

* Update first piece pickup in 3.5 HGF

* Increase shoot time again

* Move hgf first piece intake

* Add driver reset odometry binds

* Add auton align timeout

* add FilteredRelativeEncoder

Co-authored-by: simon <szhu70@users.noreply.github.com>
Co-authored-by: Owen-Zeng <Owen-Zeng@users.noreply.github.com>
Co-authored-by: mabdullah32 <mabdullah32@users.noreply.github.com>
Co-authored-by: Rahuldeb75 <Rahuldeb75@users.noreply.github.com>
Co-authored-by: metereel <Material-Energy@users.noreply.github.com>
Co-authored-by: BrianZ60 <BrianZ60@users.noreply.github.com>
Co-authored-by: rzheng287 <rzheng287@users.noreply.github.com>
Co-authored-by: urnotkool <urnotkool@users.noreply.github.com>

* Switched all encoder initalizations with FilteredRelativeEncoder, correct filter encoder getter methods

Co-authored-by: simon <szhu70@users.noreply.github.com>
Co-authored-by: urnotkool <urnotkool@users.noreply.github.com>
Co-authored-by: Rahuldeb75 <Rahuldeb75@users.noreply.github.com>
Co-authored-by: rzheng287 <rzheng287@users.noreply.github.com>
Co-authored-by: BrianZ60 <BrianZ60@users.noreply.github.com>
Co-authored-by: Owen-Zeng <Owen-Zeng@users.noreply.github.com>

* remove stupid filter

* Update AmperImpl.java

* Update SwerveModuleImpl.java

* Fix get position logic

* Keep drive encoder as relative encoder type

---------

Co-authored-by: Ivan Chen <ivanchen07@gmail.com>
Co-authored-by: Prog694 <prog692@gmail.com>
Co-authored-by: BenG49 <64862590+BenG49@users.noreply.github.com>
Co-authored-by: BenG49 <ben@goldfisher.com>
Co-authored-by: simon <szhu70@users.noreply.github.com>
Co-authored-by: Owen-Zeng <Owen-Zeng@users.noreply.github.com>
Co-authored-by: mabdullah32 <mabdullah32@users.noreply.github.com>
Co-authored-by: Rahuldeb75 <Rahuldeb75@users.noreply.github.com>
Co-authored-by: metereel <Material-Energy@users.noreply.github.com>
Co-authored-by: BrianZ60 <BrianZ60@users.noreply.github.com>
Co-authored-by: rzheng287 <rzheng287@users.noreply.github.com>
Co-authored-by: urnotkool <urnotkool@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants