Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for running fetch_dependencies.sh (building dist/) #182

Closed
aplaice opened this issue Jan 2, 2023 · 0 comments · Fixed by #195
Closed

Add test for running fetch_dependencies.sh (building dist/) #182

aplaice opened this issue Jan 2, 2023 · 0 comments · Fixed by #195

Comments

@aplaice
Copy link
Collaborator

aplaice commented Jan 2, 2023

This should only be called when Pipfile.lock is modified, to avoid unnecessary load for GitHub.

This should help us avoiding merging PRs like #176.


Having dist/ built (and cached) would also be valuable in the future for running end-to-end UI tests (once they're written), so that the CrowdAnki add-on code is exactly in the form it would be on a user's machine.


This should include a test that our dulwich build is pure python.

aplaice added a commit to aplaice/CrowdAnki that referenced this issue May 18, 2023
Fix Stvad#182.

The uploaded artifact is currently unused.

We check for changes to both Pipfile and Pipfile.lock to avoid stale a
Pipfile.lock.

This will result in some false positive runs of this workflow, when
we've, say, added a new script to Pipfile, without changing
dependencies.

We will also have false positives when only dev dependencies have been
updated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant