Allow CrowdAnki export for the default 2.1.55+ exporter #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aplaice
force-pushed
the
export_2.1.55
branch
2 times, most recently
from
325f073 to
22ebfe2
Compare
aplaice
force-pushed
the
export_2.1.55
branch
from
22ebfe2 to
eb7a3be
Compare
Fix Stvad#169. The old, legacy exporter (Tools > Preferences > Legacy import/export handling) had worked before this commit and now still works. AFAICT compatibility with Anki 2.1.50+ has been maintained (2.1.50, 2.1.54 and 2.1.55 explicitly tested). Note that in Anki 2.1.54, CrowdAnki export is only available for the old, then default (non-beta) export method, since the hook that allows easy CrowdAnki to work with the new method was AFAICT only added in 2.1.55.
aplaice
force-pushed
the
export_2.1.55
branch
from
eb7a3be to
229aa7f
Compare
|
I'm not too happy (messy code dealing with multiple Anki versions), but I can't think of any obvious improvements. (Now also tested with 2.1.56!) |
|
somehow its working now |
|
Glad that it's working! (I also added a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #169.
The old, legacy exporter (Tools > Preferences > Legacy import/export handling) had worked before this commit and now still works.
AFAICT compatibility with Anki 2.1.50+ has been maintained (2.1.50, 2.1.54 and 2.1.55 explicitly tested).
Note that in Anki 2.1.54, CrowdAnki export is only available for the old, then default (non-beta) export method, since the hook that allows easy CrowdAnki to work with the new method was AFAICT only added in 2.1.55.